Update docs and code for remaining references to 'custom bundle' #2732
+48
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/rename-custom-bundle
branch
2 times, most recently
from
9f9935b
to
a1a152a
Compare
andyw8
changed the title
vinistock
reviewed
Oct 17, 2024
andyw8
force-pushed
the
andyw8/rename-custom-bundle
branch
from
a1a152a
to
a0c23f8
Compare
vinistock
approved these changes
Oct 17, 2024
alexcrocha
approved these changes
Oct 22, 2024
| @@ -202,7 +202,7 @@ def run_bundle_install(bundle_gemfile = @gemfile) | |||
| end | |||
|
|
|||
| # If `ruby-lsp` and `debug` (and potentially `ruby-lsp-rails`) are already in the Gemfile, then we shouldn't try | |||
| # to upgrade them or else we'll produce undesired source control changes. If the custom bundle was just created | |||
| # to upgrade them or else we'll produce undesired source control changes. If the composed bundle was just created | |||
| # and any of `ruby-lsp`, `ruby-lsp-rails` or `debug` weren't a part of the Gemfile, then we need to run `bundle | |||
| # install` for the first time to generate the Gemfile.lock with them included or else Bundler will complain that | |||
| # they're missing. We can only update if the custom `.ruby-lsp/Gemfile.lock` already exists and includes all gems | |||
There was a problem hiding this comment.
We have references to a composed lockfile. I am assuming this is it. Should we also refer to it here as composed?
Suggested change
| # they're missing. We can only update if the custom `.ruby-lsp/Gemfile.lock` already exists and includes all gems | |
| # they're missing. We can only update if the composed `.ruby-lsp/Gemfile.lock` already exists and includes all gems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #2615 (comment)